Skip to content

Fix typing and set up pyright - #249

Merged
r4victor merged 13 commits into
mainfrom
pr_fix_typing
Aug 14, 2026
Merged

Fix typing and set up pyright#249
r4victor merged 13 commits into
mainfrom
pr_fix_typing

Conversation

@r4victor

@r4victor r4victor commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Fixes all the typing errors and enables pyright across the whole package. This required a big refactoring: providers constructed RawCatalogItem classes with all fields nullable that didn't represent nullability correctly and led to many typing errors. The PR drops RawCatalogItem entirely so that providers build CatalogItem directly with proper nullability typing. There are dump() and load() functions to control custom catalog CSV serialization/deserialization.

Also:

  • Introduced OfflineProvider and OnlineProvider base classes: primarily to avoid duplicate creds parsing from env for online providers.
  • Dropped RunPod spot offers as they'll be removed by the provider soon.

@r4victor
r4victor marked this pull request as ready for review August 14, 2026 07:14
@r4victor
r4victor merged commit 310de51 into main Aug 14, 2026
17 checks passed
@r4victor
r4victor deleted the pr_fix_typing branch August 14, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant